feat(virtualization): 内核虚拟化支持 #900
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
可以先merge一下主线，然后review之后，剩余的功能分多个pr提交 |
fslongjin
reviewed
Aug 27, 2024
| use crate::{ | ||
| arch::mm::barrier, | ||
| kdebug, kerror, | ||
| mm::{phys_2_virt, PhysAddr}, |
There was a problem hiding this comment.
不应该依赖这个接口，应改为MMArch::phys_2_virt
fslongjin
requested changes
Aug 27, 2024
| } | ||
|
|
||
| pub fn vmcs_load(phys_addr: PhysAddr) { | ||
| match unsafe { x86::bits64::vmx::vmptrld(phys_addr.data() as u64) } { |
There was a problem hiding this comment.
所有类似这种的，都要使用if let Err(e) = xxxx
| use crate::{ | ||
| arch::mm::barrier, | ||
| kdebug, kerror, | ||
| mm::{phys_2_virt, PhysAddr}, |
kernel/src/arch/x86_64/vm/mmu.rs
Outdated
|
|
||
| static mut TDP_ENABLED: bool = false; | ||
| static mut TDP_MMU_ENABLED: bool = true; | ||
| static mut TDP_MMU_ALLOWED: bool = unsafe { TDP_MMU_ENABLED }; |
There was a problem hiding this comment.
这个值得在kvm x86 mmu初始化之后再设置吧？不然的话他一直都是true了。
There was a problem hiding this comment.
这个值目前只是先给个默认值，后面需要动态调整的时候再调整
| VmxAsm::vmx_vmwrite(control::CR4_READ_SHADOW, cr4_flags.bits() as u64); | ||
| VmxAsm::vmx_vmwrite(guest::CR4, hw_cr4.bits() as u64); | ||
|
|
||
| if (cr4_flags ^ old_cr4).contains(Cr4::CR4_ENABLE_OS_XSAVE | Cr4::CR4_ENABLE_PROTECTION_KEY) |
There was a problem hiding this comment.
这里有问题，你想表达的意思应该是，(cr4_flags ^ old_cr4)的结果，包含Cr4::CR4_ENABLE_OS_XSAVE 或者 Cr4::CR4_ENABLE_PROTECTION_KEY
但是这种写法，指的是，(cr4_flags ^ old_cr4)的结果同时具有Cr4::CR4_ENABLE_OS_XSAVE和Cr4::CR4_ENABLE_PROTECTION_KEY
dragonosbot
added
O-x86_64
fslongjin
reviewed
Sep 20, 2024
| } | ||
| } | ||
|
|
||
| pub struct Pte { |
There was a problem hiding this comment.
fslongjin
reviewed
Sep 20, 2024
| } | ||
|
|
||
| #[allow(dead_code)] | ||
| pub mod kvm_exit { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
主要完成整体框架的搭建以及CPU虚拟化模块。目前能够成功
vmlaunch，后续会在这个pr下继续开发。下列为完成进度以及后续TODO：